-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support rlhf #184
support rlhf #184
Conversation
Jian1273
commented
Dec 12, 2023
- Add rm trainer
- Add rm data processing method
- Add some configuration parameters to support rm
CI pipeline failed. Use the following command to fix this.
|
@Jian1273 checks not passed |
Co-authored-by: qidanrui <[email protected]> Co-authored-by: junewgl <[email protected]> Co-authored-by: wangzaistone <[email protected]>
@wangzaistone Except the black check, did the submitted code passes through the test? If yes, I think we can first merge it and run black by ourselves later on. |
Yes, But first do CR and tests. @wangzaistone + @junewgl |
OK,I'm going to test the code @csunny |
After my testing, the code can run successfully, but it needs to add a data set: After running, the weights will be saved in the output directory, as shown below: cc @csunny @wangzaistone @qidanrui Thanks for your contribution @Jian1273 and I have some |
I've rerun the CI and the code passes all checks. @junewgl @Jian1273 @csunny @wangzaistone |
preprocess_function = preprocess_supervised_dataset | ||
print_function = print_supervised_dataset_example | ||
elif stage == "rm": | ||
print(111111111111111111) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
debug code remains
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oushu1zhangxiangxuan1 what 's the detail about the bug and your command ,env ? I have passed to